From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 11 Sep 2023 02:13:47 +0000 (+1200)
Subject: libcli:security: Use SELF SID constant
X-Git-Tag: tevent-0.16.0~387
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2782df62ad5259a173ace46c3dcf9cc1dbc3e8c2;p=thirdparty%2Fsamba.git

libcli:security: Use SELF SID constant

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/libcli/security/access_check.c b/libcli/security/access_check.c
index a974edf8137..e3dfe3df49c 100644
--- a/libcli/security/access_check.c
+++ b/libcli/security/access_check.c
@@ -726,9 +726,6 @@ NTSTATUS sec_access_check_ds_implicit_owner(const struct security_descriptor *sd
 {
 	uint32_t i;
 	uint32_t bits_remaining;
-	struct dom_sid self_sid;
-
-	dom_sid_parse(SID_NT_SELF, &self_sid);
 
 	*access_granted = access_desired;
 	bits_remaining = access_desired;
@@ -789,7 +786,7 @@ NTSTATUS sec_access_check_ds_implicit_owner(const struct security_descriptor *sd
 			continue;
 		}
 
-		if (dom_sid_equal(&ace->trustee, &self_sid) && replace_sid) {
+		if (dom_sid_equal(&ace->trustee, &global_sid_Self) && replace_sid) {
 			trustee = replace_sid;
 		} else {
 			trustee = &ace->trustee;