From: Victor Julien <victor@inliniac.net>
Date: Mon, 16 Sep 2013 14:24:15 +0000 (+0200)
Subject: Coverity 1038134 fix
X-Git-Tag: suricata-2.0beta2~368
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=27ea4232fedba281d4d349f23f7f52649c8fe645;p=thirdparty%2Fsuricata.git

Coverity 1038134 fix

Cleaned up error check. "ipdup" can only be non-NULL there, so remove check
that confused coverity.
---

diff --git a/src/detect-engine-address.c b/src/detect-engine-address.c
index 64f954b3f5..9e2d9356ca 100644
--- a/src/detect-engine-address.c
+++ b/src/detect-engine-address.c
@@ -605,7 +605,6 @@ int DetectAddressParseString(DetectAddress *dd, char *str)
         str++;
 
     char *ipdup = SCStrdup(str);
-
     if (unlikely(ipdup == NULL))
         return -1;
     SCLogDebug("str %s", str);
@@ -765,8 +764,7 @@ int DetectAddressParseString(DetectAddress *dd, char *str)
     return 0;
 
 error:
-    if (ipdup)
-        SCFree(ipdup);
+    SCFree(ipdup);
     return -1;
 }