From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 22 May 2023 23:15:17 +0000 (+1200)
Subject: lib:audit_logging: Check return value of json_new_object()
X-Git-Tag: talloc-2.4.1~583
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=281b616ac74c8a0e26d1636b948179dfd40e47c4;p=thirdparty%2Fsamba.git

lib:audit_logging: Check return value of json_new_object()

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/lib/audit_logging/audit_logging.c b/lib/audit_logging/audit_logging.c
index 038012f4668..ff4cabaf129 100644
--- a/lib/audit_logging/audit_logging.c
+++ b/lib/audit_logging/audit_logging.c
@@ -1185,6 +1185,12 @@ struct json_object json_get_object(struct json_object *object, const char *name)
 	json_t *v = NULL;
 	int ret = 0;
 
+	if (json_is_invalid(&o)) {
+		DBG_ERR("Unable to get object [%s]\n", name);
+		json_free(&o);
+		return o;
+	}
+
 	if (json_is_invalid(object)) {
 		DBG_ERR("Invalid JSON object, unable to get object [%s]\n",
 			name);