From: Victor Julien <victor@inliniac.net>
Date: Tue, 1 Oct 2019 08:19:53 +0000 (+0200)
Subject: detect/classtype: fix parsing error checking
X-Git-Tag: suricata-5.0.0~83
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=282e1c2520e57f43b17609f4d6d60790327bec23;p=thirdparty%2Fsuricata.git

detect/classtype: fix parsing error checking
---

diff --git a/src/detect-classtype.c b/src/detect-classtype.c
index bd25882a73..b01870ac35 100644
--- a/src/detect-classtype.c
+++ b/src/detect-classtype.c
@@ -108,9 +108,9 @@ static int DetectClasstypeSetup(DetectEngineCtx *de_ctx, Signature *s, const cha
     char parsed_ct_name[1024] = "";
     SCClassConfClasstype *ct = NULL;
 
-    if (DetectClasstypeParseRawString(rawstr, parsed_ct_name, sizeof(parsed_ct_name)) < -1) {
-        SCLogError(SC_ERR_PCRE_PARSE, "Error parsing classtype argument supplied with the "
-                   "classtype keyword");
+    if (DetectClasstypeParseRawString(rawstr, parsed_ct_name, sizeof(parsed_ct_name)) < 0) {
+        SCLogError(SC_ERR_PCRE_PARSE, "invalid value for classtype keyword: "
+                "\"%s\"", rawstr);
         goto error;
     }