From: Paul Eggert <eggert@cs.ucla.edu>
Date: Tue, 23 Jul 2019 19:25:01 +0000 (-0700)
Subject: backupfile: fix resource leak on memory failure
X-Git-Tag: v1.0~4728
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=28813cfe499c7f0ecf1eacee8b0c4be3fbfa2e47;p=thirdparty%2Fgnulib.git

backupfile: fix resource leak on memory failure

Problem found by Coverity (CID 1484214).
* lib/backupfile.c (backupfile_internal): Don’t leak dirp.
---

diff --git a/ChangeLog b/ChangeLog
index 4b7bb20544..9b994381bc 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2019-07-23  Paul Eggert  <eggert@cs.ucla.edu>
+
+	backupfile: fix resource leak on memory failure
+	Problem found by Coverity (CID 1484214).
+	* lib/backupfile.c (backupfile_internal): Don’t leak dirp.
+
 2019-07-22  Bruno Haible  <bruno@clisp.org>
 
 	Avoid missing-declarations warning in various tests.
diff --git a/lib/backupfile.c b/lib/backupfile.c
index 254c086145..82baca576c 100644
--- a/lib/backupfile.c
+++ b/lib/backupfile.c
@@ -362,6 +362,8 @@ backupfile_internal (int dir_fd, char const *file,
             break;
 
           case BACKUP_NOMEM:
+            if (dirp)
+              closedir (dirp);
             free (s);
             errno = ENOMEM;
             return NULL;