From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Tue, 19 Apr 2022 08:42:05 +0000 (+0300)
Subject: auth: auth_worker_call() - Return void instead of the connection
X-Git-Tag: 2.4.0~4123
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=28b4d923ed67ecaf55d5612cbdc5d86f5d42e50e;p=thirdparty%2Fdovecot%2Fcore.git

auth: auth_worker_call() - Return void instead of the connection

The return value is no longer necessary, and it most likely would just be
used wrong.
---

diff --git a/src/auth/auth-worker-connection.c b/src/auth/auth-worker-connection.c
index 248b0b6c6b..290ebefaa4 100644
--- a/src/auth/auth-worker-connection.c
+++ b/src/auth/auth-worker-connection.c
@@ -478,9 +478,8 @@ static const struct connection_vfuncs auth_worker_connection_funcs =
 	.input_args = worker_input_args,
 };
 
-struct auth_worker_connection *
-auth_worker_call(pool_t pool, const char *username, const char *data,
-		 auth_worker_callback_t *callback, void *context)
+void auth_worker_call(pool_t pool, const char *username, const char *data,
+		      auth_worker_callback_t *callback, void *context)
 {
 	struct auth_worker_connection *worker;
 	struct auth_worker_request *request;
@@ -510,7 +509,6 @@ auth_worker_call(pool_t pool, const char *username, const char *data,
 		/* reached the limit, queue the request */
 		aqueue_append(worker_request_queue, &request);
 	}
-	return worker;
 }
 
 void auth_worker_connection_resume_input(struct auth_worker_connection *worker)
diff --git a/src/auth/auth-worker-connection.h b/src/auth/auth-worker-connection.h
index a4dd76417f..bdce677dbf 100644
--- a/src/auth/auth-worker-connection.h
+++ b/src/auth/auth-worker-connection.h
@@ -8,9 +8,8 @@ struct auth_worker_connection;
 typedef bool auth_worker_callback_t(struct auth_worker_connection *conn,
 				    const char *const *args, void *context);
 
-struct auth_worker_connection * ATTR_NOWARN_UNUSED_RESULT
-auth_worker_call(pool_t pool, const char *username, const char *data,
-		 auth_worker_callback_t *callback, void *context);
+void auth_worker_call(pool_t pool, const char *username, const char *data,
+		      auth_worker_callback_t *callback, void *context);
 void auth_worker_connection_resume_input(struct auth_worker_connection *conn);
 
 void auth_worker_connection_init(void);