From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Mon, 7 Jun 2021 11:29:19 +0000 (+0200)
Subject: core: disable "update" units in the initramfs
X-Git-Tag: v249-rc1~83^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=294eace024b0e6c34cb64e3bb4f8958bb98ee00b;p=thirdparty%2Fsystemd.git

core: disable "update" units in the initramfs

Initially I wanted to add ConditionPathExists=!/etc/initrd-release in various
units (ldconfig.service, systemd-sysusers.service, systemd-hwdb-update.service,
systemd-journal-catalog-update, systemd-update-done.service), but I think it's
better to just disable the mechanism in the initrd altogether. Initrd images
are put together in a very particular way, and there is not need to do
post-update steps on them. If a unit from some other package winds up in the
initrd, we wouldn't want to invoke it either.

Also, any modifications are ephemeral, so any update would happen on every
use. And finally, initrd images are all about speed, and we shouldn't invoke
any unneeded services.
---

diff --git a/src/shared/condition.c b/src/shared/condition.c
index d4d9eacc4bd..b86312548d0 100644
--- a/src/shared/condition.c
+++ b/src/shared/condition.c
@@ -675,6 +675,11 @@ static int condition_test_needs_update(Condition *c, char **env) {
         if (r > 0)
                 return b;
 
+        if (in_initrd()) {
+                log_debug("We are in an initrd, not doing any updates.");
+                return false;
+        }
+
         if (!path_is_absolute(c->parameter)) {
                 log_debug("Specified condition parameter '%s' is not absolute, assuming an update is needed.", c->parameter);
                 return true;