From: Nick Mathewson <nickm@torproject.org>
Date: Thu, 9 Apr 2020 11:54:23 +0000 (-0400)
Subject: Make sure that we free 'addr' at the end of a pair of addr tests
X-Git-Tag: tor-0.4.5.0-alpha-dev~63
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=29693b83bcfef517469d3afe7a54195adf7f378f;p=thirdparty%2Ftor.git

Make sure that we free 'addr' at the end of a pair of addr tests

Fixes a couple of Coverity warnings about possible memory leaks.
Bug not in any released Tor.
---

diff --git a/src/test/test_addr.c b/src/test/test_addr.c
index 82d388b2aa..cf5aad7e71 100644
--- a/src/test/test_addr.c
+++ b/src/test/test_addr.c
@@ -1751,10 +1751,9 @@ test_addr_is_valid(void *arg)
   get_af_unspec(test_addr);
   TEST_ADDR_VALIDITY(test_addr, 0, 0);
   TEST_ADDR_VALIDITY(test_addr, 1, 0);
-  tor_free(test_addr);
 
  done:
-  ;
+  tor_free(test_addr);
 }
 
 #define TEST_ADDR_IS_NULL(a, rv) STMT_BEGIN                 \
@@ -1797,10 +1796,9 @@ test_addr_is_null(void *arg)
   /* Test for address family AF_UNSPEC. */
   get_af_unspec(test_addr);
   TEST_ADDR_IS_NULL(test_addr, 1);
-  tor_free(test_addr);
 
  done:
-  ;
+  tor_free(test_addr);
 }
 
 #ifndef COCCI