From: Tim Rühsen <tim.ruehsen@gmx.de>
Date: Wed, 9 Oct 2019 16:27:11 +0000 (+0200)
Subject: lib/sslv2_compat.c: Check return value of _gnutls_generate_session_id()
X-Git-Tag: gnutls_3_6_11~32^2~5
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2a66896e291f3ab74ac778e4e91aa95fee282def;p=thirdparty%2Fgnutls.git

lib/sslv2_compat.c: Check return value of _gnutls_generate_session_id()

Fixes Coverity issue 1454649

Signed-off-by: Tim Rühsen <tim.ruehsen@gmx.de>
---

diff --git a/lib/sslv2_compat.c b/lib/sslv2_compat.c
index 9d247ba4cb..4dd62d01c1 100644
--- a/lib/sslv2_compat.c
+++ b/lib/sslv2_compat.c
@@ -241,10 +241,12 @@ _gnutls_read_client_hello_v2(gnutls_session_t session, uint8_t * data,
 		session->internals.resumed = RESUME_TRUE;
 		return 0;
 	} else {
-		_gnutls_generate_session_id(session->security_parameters.
-					    session_id,
-					    &session->security_parameters.
-					    session_id_size);
+		ret = _gnutls_generate_session_id(
+			session->security_parameters.session_id,
+			&session->security_parameters.session_id_size);
+		if (ret < 0)
+			return gnutls_assert_val(ret);
+
 		session->internals.resumed = RESUME_FALSE;
 	}