From: Daan De Meyer <daan.j.demeyer@gmail.com>
Date: Mon, 9 May 2022 07:50:32 +0000 (+0200)
Subject: shared: Fix memory leak in bus_append_execute_property()
X-Git-Tag: v251-rc3~37
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2aaf6d407e8541985a15b7106abf6fbdfed0766a;p=thirdparty%2Fsystemd.git

shared: Fix memory leak in bus_append_execute_property()

Fixes #23317
---

diff --git a/src/shared/bus-unit-util.c b/src/shared/bus-unit-util.c
index d78d75bf0f8..a326ca30a9a 100644
--- a/src/shared/bus-unit-util.c
+++ b/src/shared/bus-unit-util.c
@@ -1955,7 +1955,7 @@ static int bus_append_execute_property(sd_bus_message *m, const char *field, con
                         path_simplify(source);
 
                         if (isempty(destination)) {
-                                r = strv_extend(&sources, TAKE_PTR(source));
+                                r = strv_consume(&sources, TAKE_PTR(source));
                                 if (r < 0)
                                         return bus_log_create_error(r);
                         } else {