From: Volker Lendecke <vl@samba.org>
Date: Wed, 31 Aug 2022 15:35:03 +0000 (+0200)
Subject: librpc: Simplify ndr_size_dom_sid28()
X-Git-Tag: talloc-2.4.0~1143
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2ae7ad97ab2837df96a979073c7462b689ac0038;p=thirdparty%2Fsamba.git

librpc: Simplify ndr_size_dom_sid28()

all_zero() treats a NULL pointer as true.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/librpc/ndr/ndr_sec_helper.c b/librpc/ndr/ndr_sec_helper.c
index 3adb46f5b9c..eb0171a504d 100644
--- a/librpc/ndr/ndr_sec_helper.c
+++ b/librpc/ndr/ndr_sec_helper.c
@@ -129,8 +129,6 @@ size_t ndr_size_dom_sid(const struct dom_sid *sid, int flags)
 
 size_t ndr_size_dom_sid28(const struct dom_sid *sid, int flags)
 {
-	if (!sid) return 0;
-
 	if (all_zero((const uint8_t *)sid, sizeof(struct dom_sid))) {
 		return 0;
 	}