From: Pavel Filipenský <pfilipen@redhat.com>
Date: Thu, 5 Aug 2021 13:17:57 +0000 (+0200)
Subject: s3:winbind: Move up some code in winbindd_getusersids.c
X-Git-Tag: tevent-0.13.0~154
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2b5c86118d4c0bba23a0db61413fa288425cc8ba;p=thirdparty%2Fsamba.git

s3:winbind: Move up some code in winbindd_getusersids.c

Signed-off-by: Pavel Filipenský <pfilipen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source3/winbindd/winbindd_getusersids.c b/source3/winbindd/winbindd_getusersids.c
index 1f2546a7ba1..c2347473f5f 100644
--- a/source3/winbindd/winbindd_getusersids.c
+++ b/source3/winbindd/winbindd_getusersids.c
@@ -101,6 +101,9 @@ NTSTATUS winbindd_getusersids_recv(struct tevent_req *req,
 	}
 
 	result = talloc_strdup(response, "");
+	if (result == NULL) {
+		return NT_STATUS_NO_MEMORY;
+	}
 
 	for (i=0; i<state->num_sids; i++) {
 		talloc_asprintf_addbuf(
@@ -109,9 +112,6 @@ NTSTATUS winbindd_getusersids_recv(struct tevent_req *req,
 			dom_sid_str_buf(&state->sids[i], &sidbuf));
 	}
 
-	if (result == NULL) {
-		return NT_STATUS_NO_MEMORY;
-	}
 
 	response->data.num_entries = state->num_sids;
 	response->extra_data.data = result;