From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Thu, 15 Nov 2018 09:25:46 +0000 (-0800)
Subject: Fix a possible reference leak in _socket.getaddrinfo(). (GH-10543)
X-Git-Tag: v3.6.8rc1~103
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2b6e77e778bc6f5b69384d6c13cb2015c13fc81e;p=thirdparty%2FPython%2Fcpython.git

Fix a possible reference leak in _socket.getaddrinfo(). (GH-10543)


"single" needs to be decrefed if PyList_Append() fails.
(cherry picked from commit 4c596d54aa6a55e9d2a3db78891e656ebbfb63c8)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
---

diff --git a/Modules/socketmodule.c b/Modules/socketmodule.c
index ed3166740278..c940f1b81693 100644
--- a/Modules/socketmodule.c
+++ b/Modules/socketmodule.c
@@ -6075,9 +6075,11 @@ socket_getaddrinfo(PyObject *self, PyObject *args, PyObject* kwargs)
         if (single == NULL)
             goto err;
 
-        if (PyList_Append(all, single))
+        if (PyList_Append(all, single)) {
+            Py_DECREF(single);
             goto err;
-        Py_XDECREF(single);
+        }
+        Py_DECREF(single);
     }
     Py_XDECREF(idna);
     if (res0)