From: Noel Power <noel.power@suse.com>
Date: Tue, 18 Jun 2019 10:47:29 +0000 (+0000)
Subject: lib/krb5_wrap: clang: Fix warning: Null pointer passed as an argument
X-Git-Tag: ldb-2.0.5~119
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2b7236ffe1a0454756b76f8dc302649e92cefbaa;p=thirdparty%2Fsamba.git

lib/krb5_wrap: clang: Fix warning: Null pointer passed as an argument

Fixes:

lib/krb5_wrap/krb5_samba.c:3241:3: warning: Null pointer passed as an argument to a 'nonnull' parameter <--[clang]
                memcpy(gss_cksum + 28, in_data->data, orig_length);
                ^

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
---

diff --git a/lib/krb5_wrap/krb5_samba.c b/lib/krb5_wrap/krb5_samba.c
index eac86e6754b..37257ddfe03 100644
--- a/lib/krb5_wrap/krb5_samba.c
+++ b/lib/krb5_wrap/krb5_samba.c
@@ -3234,7 +3234,7 @@ static krb5_error_code ads_create_gss_checksum(krb5_data *in_data, /* [inout] */
 
 	SIVAL(gss_cksum, 20, gss_flags);
 
-	if (orig_length) {
+	if (orig_length && in_data->data != NULL) {
 		SSVAL(gss_cksum, 24, 1); /* The Delegation Option identifier */
 		SSVAL(gss_cksum, 26, orig_length);
 		/* Copy the kerberos KRB_CRED data */