From: Mukund Sivaraman <muks@isc.org>
Date: Fri, 3 May 2013 00:30:19 +0000 (+0530)
Subject: [2850] Make ZoneTableSegmentLocal::reset() throw NotImplemented exception
X-Git-Tag: bind10-1.2.0beta1-release~467^2~67
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2b96d4487c517ab209a1ca5fce4af877fecae0a7;p=thirdparty%2Fkea.git

[2850] Make ZoneTableSegmentLocal::reset() throw NotImplemented exception
---

diff --git a/src/lib/datasrc/memory/zone_table_segment_local.cc b/src/lib/datasrc/memory/zone_table_segment_local.cc
index dbcb54f1a2..7bafa1174c 100644
--- a/src/lib/datasrc/memory/zone_table_segment_local.cc
+++ b/src/lib/datasrc/memory/zone_table_segment_local.cc
@@ -41,7 +41,9 @@ void
 ZoneTableSegmentLocal::reset(MemorySegmentOpenMode,
                              isc::data::ConstElementPtr)
 {
-    // This method doesn't do anything in this implementation.
+    isc_throw(isc::NotImplemented,
+              "ZoneTableSegmentLocal::reset() is not implemented and "
+              "should not be used.");
 }
 
 // After more methods' definitions are added here, it would be a good
diff --git a/src/lib/datasrc/memory/zone_table_segment_local.h b/src/lib/datasrc/memory/zone_table_segment_local.h
index 6430d2a468..cbb3b27fb1 100644
--- a/src/lib/datasrc/memory/zone_table_segment_local.h
+++ b/src/lib/datasrc/memory/zone_table_segment_local.h
@@ -61,9 +61,9 @@ public:
         return (true);
     }
 
-    /// \brief This method currently doesn't do anything.
+    /// \brief This method is not implemented.
     ///
-    /// \c mode and \c params args are currently ignored.
+    /// \throw isc::NotImplemented
     virtual void reset(MemorySegmentOpenMode mode,
                        isc::data::ConstElementPtr params);
 
diff --git a/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc b/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc
index d8d5d06b74..8afc1ac8b8 100644
--- a/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc
+++ b/src/lib/datasrc/tests/memory/zone_table_segment_unittest.cc
@@ -52,10 +52,12 @@ TEST_F(ZoneTableSegmentTest, create) {
 }
 
 TEST_F(ZoneTableSegmentTest, reset) {
-    // reset() currently doesn't do anything in a local segment. But
-    // test the API.
-    ztable_segment_->reset(ZoneTableSegment::CREATE,
-                           Element::fromJSON("{}"));
+    // reset() should throw that it's not implemented so that any
+    // accidental calls are found out.
+    EXPECT_THROW({
+        ztable_segment_->reset(ZoneTableSegment::CREATE,
+                               Element::fromJSON("{}"));
+    }, isc::NotImplemented);
 }
 
 // Helper function to check const and non-const methods.