From: Viktor Szakats Date: Sun, 2 Feb 2025 13:45:21 +0000 (+0100) Subject: cmake/Find: set `_FOUND` for compatibility when found via `pkg-config` X-Git-Tag: curl-8_12_1~60 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2b9b3ec579d019fe55f49412ade91cc831403c58;p=thirdparty%2Fcurl.git cmake/Find: set `_FOUND` for compatibility when found via `pkg-config` For Find modules where `` is not fully uppercase. `` is case-exact name used in the Find modules filename: `CMake/Find.cmake`. `find_package_handle_standard_args()` sets both `_FOUND` and `_FOUND` when detecting the dependency. Some CMake code relies on this and 3rd-party code may rely on it too. Make sure to set the latter variant when detecting the dependency via `pkg-config`, where we don't call `find_package_handle_standard_args()`. CMake sets these variable to `TRUE` (not `ON` or `1`). Replicate this for compatibility. Closes #16153 --- diff --git a/CMake/FindBrotli.cmake b/CMake/FindBrotli.cmake index 8a692bda10..b72f1906ff 100644 --- a/CMake/FindBrotli.cmake +++ b/CMake/FindBrotli.cmake @@ -51,6 +51,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(BROTLI_FOUND AND BROTLIDEC_FOUND) + set(Brotli_FOUND TRUE) list(APPEND BROTLIDEC_LIBRARIES ${BROTLI_LIBRARIES}) # order is significant: brotlidec then brotlicommon list(REVERSE BROTLIDEC_LIBRARIES) list(REMOVE_DUPLICATES BROTLIDEC_LIBRARIES) diff --git a/CMake/FindCares.cmake b/CMake/FindCares.cmake index 67dec09465..cc47e2d331 100644 --- a/CMake/FindCares.cmake +++ b/CMake/FindCares.cmake @@ -48,6 +48,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(CARES_FOUND) + set(Cares_FOUND TRUE) string(REPLACE ";" " " CARES_CFLAGS "${CARES_CFLAGS}") message(STATUS "Found Cares (via pkg-config): ${CARES_INCLUDE_DIRS} (found version \"${CARES_VERSION}\")") else() diff --git a/CMake/FindLibgsasl.cmake b/CMake/FindLibgsasl.cmake index c0ce67393f..c726ce1a49 100644 --- a/CMake/FindLibgsasl.cmake +++ b/CMake/FindLibgsasl.cmake @@ -48,6 +48,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(LIBGSASL_FOUND) + set(Libgsasl_FOUND TRUE) string(REPLACE ";" " " LIBGSASL_CFLAGS "${LIBGSASL_CFLAGS}") message(STATUS "Found Libgsasl (via pkg-config): ${LIBGSASL_INCLUDE_DIRS} (found version \"${LIBGSASL_VERSION}\")") else() diff --git a/CMake/FindLibidn2.cmake b/CMake/FindLibidn2.cmake index a8887e8954..f8f00f0c79 100644 --- a/CMake/FindLibidn2.cmake +++ b/CMake/FindLibidn2.cmake @@ -48,6 +48,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(LIBIDN2_FOUND) + set(Libidn2_FOUND TRUE) string(REPLACE ";" " " LIBIDN2_CFLAGS "${LIBIDN2_CFLAGS}") message(STATUS "Found Libidn2 (via pkg-config): ${LIBIDN2_INCLUDE_DIRS} (found version \"${LIBIDN2_VERSION}\")") else() diff --git a/CMake/FindLibpsl.cmake b/CMake/FindLibpsl.cmake index 0d96995179..d6fde4b2d0 100644 --- a/CMake/FindLibpsl.cmake +++ b/CMake/FindLibpsl.cmake @@ -48,6 +48,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(LIBPSL_FOUND AND LIBPSL_INCLUDE_DIRS) + set(Libpsl_FOUND TRUE) string(REPLACE ";" " " LIBPSL_CFLAGS "${LIBPSL_CFLAGS}") message(STATUS "Found Libpsl (via pkg-config): ${LIBPSL_INCLUDE_DIRS} (found version \"${LIBPSL_VERSION}\")") else() diff --git a/CMake/FindLibrtmp.cmake b/CMake/FindLibrtmp.cmake index dd3fb9e010..50fc9692bd 100644 --- a/CMake/FindLibrtmp.cmake +++ b/CMake/FindLibrtmp.cmake @@ -48,6 +48,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(LIBRTMP_FOUND AND LIBRTMP_INCLUDE_DIRS) + set(Librtmp_FOUND TRUE) string(REPLACE ";" " " LIBRTMP_CFLAGS "${LIBRTMP_CFLAGS}") message(STATUS "Found Librtmp (via pkg-config): ${LIBRTMP_INCLUDE_DIRS} (found version \"${LIBRTMP_VERSION}\")") else() diff --git a/CMake/FindLibssh.cmake b/CMake/FindLibssh.cmake index b8b4a51a4a..e2b27d975c 100644 --- a/CMake/FindLibssh.cmake +++ b/CMake/FindLibssh.cmake @@ -48,6 +48,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(LIBSSH_FOUND) + set(Libssh_FOUND TRUE) string(REPLACE ";" " " LIBSSH_CFLAGS "${LIBSSH_CFLAGS}") message(STATUS "Found Libssh (via pkg-config): ${LIBSSH_INCLUDE_DIRS} (found version \"${LIBSSH_VERSION}\")") else() diff --git a/CMake/FindLibssh2.cmake b/CMake/FindLibssh2.cmake index dfb0582a8b..0b81ecb3cf 100644 --- a/CMake/FindLibssh2.cmake +++ b/CMake/FindLibssh2.cmake @@ -48,6 +48,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(LIBSSH2_FOUND AND LIBSSH2_INCLUDE_DIRS) + set(Libssh2_FOUND TRUE) string(REPLACE ";" " " LIBSSH2_CFLAGS "${LIBSSH2_CFLAGS}") message(STATUS "Found Libssh2 (via pkg-config): ${LIBSSH2_INCLUDE_DIRS} (found version \"${LIBSSH2_VERSION}\")") else() diff --git a/CMake/FindLibuv.cmake b/CMake/FindLibuv.cmake index 8255eaa135..b16b3554f6 100644 --- a/CMake/FindLibuv.cmake +++ b/CMake/FindLibuv.cmake @@ -48,6 +48,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(LIBUV_FOUND) + set(Libuv_FOUND TRUE) string(REPLACE ";" " " LIBUV_CFLAGS "${LIBUV_CFLAGS}") message(STATUS "Found Libuv (via pkg-config): ${LIBUV_INCLUDE_DIRS} (found version \"${LIBUV_VERSION}\")") else() diff --git a/CMake/FindMbedTLS.cmake b/CMake/FindMbedTLS.cmake index c3ba27d8a7..83f13712e4 100644 --- a/CMake/FindMbedTLS.cmake +++ b/CMake/FindMbedTLS.cmake @@ -60,6 +60,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(MBEDTLS_FOUND AND MBEDX509_FOUND AND MBEDCRYPTO_FOUND) + set(MbedTLS_FOUND TRUE) list(APPEND MBEDTLS_LIBRARIES ${MBEDX509_LIBRARIES} ${MBEDCRYPTO_LIBRARIES}) list(REVERSE MBEDTLS_LIBRARIES) list(REMOVE_DUPLICATES MBEDTLS_LIBRARIES) diff --git a/CMake/FindNettle.cmake b/CMake/FindNettle.cmake index 753633a23e..c2decf6e7b 100644 --- a/CMake/FindNettle.cmake +++ b/CMake/FindNettle.cmake @@ -48,6 +48,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(NETTLE_FOUND) + set(Nettle_FOUND TRUE) string(REPLACE ";" " " NETTLE_CFLAGS "${NETTLE_CFLAGS}") message(STATUS "Found Nettle (via pkg-config): ${NETTLE_INCLUDE_DIRS} (found version \"${NETTLE_VERSION}\")") else() diff --git a/CMake/FindQuiche.cmake b/CMake/FindQuiche.cmake index 092aff89e5..6939c64e0f 100644 --- a/CMake/FindQuiche.cmake +++ b/CMake/FindQuiche.cmake @@ -48,6 +48,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(QUICHE_FOUND) + set(Quiche_FOUND TRUE) string(REPLACE ";" " " QUICHE_CFLAGS "${QUICHE_CFLAGS}") message(STATUS "Found Quiche (via pkg-config): ${QUICHE_INCLUDE_DIRS} (found version \"${QUICHE_VERSION}\")") else() diff --git a/CMake/FindRustls.cmake b/CMake/FindRustls.cmake index 51f45060b7..564b08ce15 100644 --- a/CMake/FindRustls.cmake +++ b/CMake/FindRustls.cmake @@ -48,6 +48,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(RUSTLS_FOUND) + set(Rustls_FOUND TRUE) string(REPLACE ";" " " RUSTLS_CFLAGS "${RUSTLS_CFLAGS}") message(STATUS "Found Rustls (via pkg-config): ${RUSTLS_INCLUDE_DIRS} (found version \"${RUSTLS_VERSION}\")") else() diff --git a/CMake/FindWolfSSL.cmake b/CMake/FindWolfSSL.cmake index 3163fee9b9..e33fef8711 100644 --- a/CMake/FindWolfSSL.cmake +++ b/CMake/FindWolfSSL.cmake @@ -57,6 +57,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(WOLFSSL_FOUND) + set(WolfSSL_FOUND TRUE) string(REPLACE ";" " " WOLFSSL_CFLAGS "${WOLFSSL_CFLAGS}") message(STATUS "Found WolfSSL (via pkg-config): ${WOLFSSL_INCLUDE_DIRS} (found version \"${WOLFSSL_VERSION}\")") else() diff --git a/CMake/FindZstd.cmake b/CMake/FindZstd.cmake index dbfede708b..0ea1fef467 100644 --- a/CMake/FindZstd.cmake +++ b/CMake/FindZstd.cmake @@ -57,6 +57,7 @@ if(CURL_USE_PKGCONFIG AND endif() if(ZSTD_FOUND) + set(Zstd_FOUND TRUE) string(REPLACE ";" " " ZSTD_CFLAGS "${ZSTD_CFLAGS}") message(STATUS "Found Zstd (via pkg-config): ${ZSTD_INCLUDE_DIRS} (found version \"${ZSTD_VERSION}\")") else()