From: Volker Lendecke <vl@samba.org>
Date: Fri, 20 Sep 2024 19:01:52 +0000 (+0200)
Subject: smbd: Slightly simplify unix_perms_from_wire()
X-Git-Tag: tdb-1.4.13~1067
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2ba46540c9789f2498b8b5a3a434c3678936d25e;p=thirdparty%2Fsamba.git

smbd: Slightly simplify unix_perms_from_wire()

Avoid an else-branch, we return before

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/smbd/smb2_trans2.c b/source3/smbd/smb2_trans2.c
index de0105e5c21..29c1ce44bb2 100644
--- a/source3/smbd/smb2_trans2.c
+++ b/source3/smbd/smb2_trans2.c
@@ -902,10 +902,9 @@ NTSTATUS unix_perms_from_wire(connection_struct *conn,
 	if (perms == SMB_MODE_NO_CHANGE) {
 		if (!VALID_STAT(*psbuf)) {
 			return NT_STATUS_INVALID_PARAMETER;
-		} else {
-			*ret_perms = psbuf->st_ex_mode;
-			return NT_STATUS_OK;
 		}
+		*ret_perms = psbuf->st_ex_mode;
+		return NT_STATUS_OK;
 	}
 
 	ret = wire_perms_to_unix(perms);