From: Günther Deschner <gd@samba.org>
Date: Thu, 2 Oct 2025 14:04:42 +0000 (+0200)
Subject: s3-smbd: send notifications for ACL changes
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2be7c0c2f927042843fb8a2ea0b9c67d1f969d00;p=thirdparty%2Fsamba.git

s3-smbd: send notifications for ACL changes

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14148

Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Nov  6 02:42:06 UTC 2025 on atb-devel-224
---

diff --git a/selftest/knownfail b/selftest/knownfail
index 36ac6a12510..ab2d79d7114 100644
--- a/selftest/knownfail
+++ b/selftest/knownfail
@@ -191,7 +191,6 @@
 ^samba3.smb2.create.blob
 ^samba3.smb2.create.open
 ^samba3.smb2.notify.rec
-^samba3.smb2.notify.security
 ^samba3.smb2.durable-open.delete_on_close2
 ^samba3.smb2.durable-v2-open.app-instance
 ^samba3.smb2.durable-open.reopen1a-lease\(ad_dc\)$
diff --git a/source3/smbd/smb2_nttrans.c b/source3/smbd/smb2_nttrans.c
index 32ec5a9b5c8..780fc64e529 100644
--- a/source3/smbd/smb2_nttrans.c
+++ b/source3/smbd/smb2_nttrans.c
@@ -167,9 +167,16 @@ NTSTATUS set_sd(files_struct *fsp, struct security_descriptor *psd,
 
 	sd_fsp = metadata_fsp(fsp);
 	status = SMB_VFS_FSET_NT_ACL(sd_fsp, security_info_sent, psd);
-
 	TALLOC_FREE(psd);
 
+	if (NT_STATUS_IS_OK(status)) {
+		notify_fname(fsp->conn,
+			     NOTIFY_ACTION_MODIFIED,
+			     FILE_NOTIFY_CHANGE_SECURITY,
+			     fsp->fsp_name,
+			     NULL);
+	}
+
 	return status;
 }