From: Jeremy Allison <jra@samba.org>
Date: Tue, 1 May 2018 18:51:43 +0000 (-0700)
Subject: s3: printing: Remove the LSEEK in printing_pread_data() and use read_file() instead.
X-Git-Tag: ldb-1.4.0~414
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2bea1103e5d322515eac7ddae5e1444ceb5e7b97;p=thirdparty%2Fsamba.git

s3: printing: Remove the LSEEK in printing_pread_data() and use read_file() instead.

Removes last-but-one user of SMB_VFS_READ.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c
index 6bc48ae3634..a96122a15b2 100644
--- a/source3/printing/nt_printing.c
+++ b/source3/printing/nt_printing.c
@@ -324,17 +324,15 @@ static ssize_t printing_pread_data(files_struct *fsp,
 	size_t total=0;
 	off_t in_pos = *poff;
 
-	in_pos = SMB_VFS_LSEEK(fsp, in_pos, SEEK_SET);
-	if (in_pos == (off_t)-1) {
-		return -1;
-	}
 	/* Don't allow integer wrap on read. */
 	if (in_pos + byte_count < in_pos) {
 		return -1;
 	}
 
 	while (total < byte_count) {
-		ssize_t ret = SMB_VFS_READ(fsp, buf + total,
+		ssize_t ret = read_file(fsp,
+					buf + total,
+					in_pos,
 					byte_count - total);
 
 		if (ret == 0) {