From: Xtreak <tir.karthi@gmail.com>
Date: Mon, 13 May 2019 14:48:52 +0000 (+0530)
Subject: bpo-36903: Fix ResourceWarning in test_logging (GH-13283)
X-Git-Tag: v3.8.0b1~388
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2c10538d11fa9be9a1a9f21605861e10ec4fa207;p=thirdparty%2FPython%2Fcpython.git

bpo-36903: Fix ResourceWarning in test_logging (GH-13283)
---

diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index bc99c3adbe34..b884753ad397 100644
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -684,6 +684,7 @@ class HandlerTest(BaseTest):
 
         self.assertEqual(len(logging._handlers), 0)
         refed_h = _OurHandler()
+        self.addCleanup(refed_h.sub_handler.stream.close)
         refed_h.name = 'because we need at least one for this test'
         self.assertGreater(len(logging._handlers), 0)
         self.assertGreater(len(logging._at_fork_reinit_lock_weakset), 1)