From: Álvaro Herrera <alvherre@kurilemu.de>
Date: Wed, 8 Apr 2026 20:58:56 +0000 (+0200)
Subject: Simplify declaration of memcpy target
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2cff363715efe3fd2dfbb04f9aa52fd5638f8f0d;p=thirdparty%2Fpostgresql.git

Simplify declaration of memcpy target

The existing one is understandable failing on (some?) 32-bit platforms.

Reported-by: Tomas Vondra <tomas@vondra.me>
Suggested-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/1c197f2d-49a2-4830-8dde-55867218b62d@vondra.me
---

diff --git a/src/backend/commands/repack.c b/src/backend/commands/repack.c
index 20dad22c4b7..58e3867246f 100644
--- a/src/backend/commands/repack.c
+++ b/src/backend/commands/repack.c
@@ -2710,11 +2710,7 @@ restore_tuple(BufFile *file, Relation relation, TupleTableSlot *slot)
 		{
 			CompactAttribute *attr = TupleDescCompactAttr(desc, i);
 			varlena    *varlen;
-			union
-			{
-				alignas(int32) varlena hdr;
-				char		data[sizeof(void *)];
-			}			chunk_header;
+			uint64		chunk_header;
 			void	   *value;
 			Size		varlensz;