From: Zbigniew Jędrzejewski-Szmek <zbyszek@amutable.com>
Date: Thu, 26 Mar 2026 12:47:44 +0000 (+0100)
Subject: basic/proc-cmdline: extend comments
X-Git-Tag: v261-rc1~713
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2d2dc38f0028bab3fa11c7a43ab26f6adf10b544;p=thirdparty%2Fsystemd.git

basic/proc-cmdline: extend comments

Inspired by the discussion in #41161.

Also change the order of flags to be more logical. First the option
to specify at what fields we look, then the option to specify how we
return their name, the the value, and finally what to do if the value
is missing.
---

diff --git a/src/basic/proc-cmdline.h b/src/basic/proc-cmdline.h
index 42a8ef1eb9c..6abf57ac3c1 100644
--- a/src/basic/proc-cmdline.h
+++ b/src/basic/proc-cmdline.h
@@ -4,10 +4,15 @@
 #include "basic-forward.h"
 
 typedef enum ProcCmdlineFlags {
-        PROC_CMDLINE_STRIP_RD_PREFIX    = 1 << 0, /* automatically strip "rd." prefix if it is set (and we are in the initrd, since otherwise we'd not consider it anyway) */
-        PROC_CMDLINE_VALUE_OPTIONAL     = 1 << 1, /* the value is optional (for boolean switches that can omit the value) */
-        PROC_CMDLINE_RD_STRICT          = 1 << 2, /* ignore this in the initrd */
-        PROC_CMDLINE_TRUE_WHEN_MISSING  = 1 << 3, /* default to true when the key is missing for bool */
+        PROC_CMDLINE_RD_STRICT          = 1 << 0, /* Only look at options with the "rd." prefix when in the initrd and only
+                                                   * at options without the prefix when not in the initrd.
+                                                   */
+        PROC_CMDLINE_STRIP_RD_PREFIX    = 1 << 1, /* Automatically strip "rd." prefix if we are in the initrd.
+                                                   * When this is specified, the handler function must check for unprefixed
+                                                   * option names. */
+        PROC_CMDLINE_VALUE_OPTIONAL     = 1 << 2, /* The value is optional (for boolean switches that can omit the value). */
+        PROC_CMDLINE_TRUE_WHEN_MISSING  = 1 << 3, /* Make proc_cmdline_get_bool() return true instead of false (the default)
+                                                   * when the key is not present on the command line. */
 } ProcCmdlineFlags;
 
 typedef int (*proc_cmdline_parse_t)(const char *key, const char *value, void *data);