From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Thu, 18 Jul 2019 09:28:55 +0000 (+0200)
Subject: shared/conf-parser: be nice and ignore lines without "="
X-Git-Tag: v243-rc1~90^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2d4fffb00bbf528683946ee04e04980549124b0a;p=thirdparty%2Fsystemd.git

shared/conf-parser: be nice and ignore lines without "="

We generally don't treat syntax error as fatal, but in this case we would
completely refuse to load the file. I think we should treat the the same
as assignment outside of a section, or an unknown key name.
---

diff --git a/src/shared/conf-parser.c b/src/shared/conf-parser.c
index 62fc1c97b71..c3af2308703 100644
--- a/src/shared/conf-parser.c
+++ b/src/shared/conf-parser.c
@@ -239,7 +239,6 @@ static int parse_line(
         }
 
         if (sections && !*section) {
-
                 if (!(flags & CONFIG_PARSE_RELAXED) && !*section_ignored)
                         log_syntax(unit, LOG_WARNING, filename, line, 0, "Assignment outside of section. Ignoring.");
 
@@ -247,10 +246,9 @@ static int parse_line(
         }
 
         e = strchr(l, '=');
-        if (!e) {
-                log_syntax(unit, LOG_WARNING, filename, line, 0, "Missing '='.");
-                return -EINVAL;
-        }
+        if (!e)
+                return log_syntax(unit, LOG_WARNING, filename, line, 0,
+                                  "Missing '=', ignoring line.");
 
         *e = 0;
         e++;