From: Jason <jason.daurus@gmail.com>
Date: Tue, 4 Feb 2020 15:03:32 +0000 (+0800)
Subject: fix(compiler-sfc): handle empty nodes with src attribute (#695)
X-Git-Tag: v3.0.0-alpha.5~119
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2d56dfdc4fcf824bba4c0166ca5471258c4f883b;p=thirdparty%2Fvuejs%2Fcore.git

fix(compiler-sfc): handle empty nodes with src attribute (#695)
---

diff --git a/packages/compiler-sfc/__tests__/parse.spec.ts b/packages/compiler-sfc/__tests__/parse.spec.ts
index a55e2e6b28..fcb59061ae 100644
--- a/packages/compiler-sfc/__tests__/parse.spec.ts
+++ b/packages/compiler-sfc/__tests__/parse.spec.ts
@@ -73,6 +73,13 @@ h1 { color: red }
     expect(parse(`<custom/>`).descriptor.customBlocks.length).toBe(0)
   })
 
+  test('handle empty nodes with src attribute', () => {
+    const { descriptor } = parse(`<script src="com"/>`)
+    expect(descriptor.script).toBeTruthy()
+    expect(descriptor.script!.content).toBeFalsy()
+    expect(descriptor.script!.attrs['src']).toBe('com')
+  })
+
   test('nested templates', () => {
     const content = `
     <template v-if="ok">ok</template>
diff --git a/packages/compiler-sfc/src/parse.ts b/packages/compiler-sfc/src/parse.ts
index 1953027c90..da3753643f 100644
--- a/packages/compiler-sfc/src/parse.ts
+++ b/packages/compiler-sfc/src/parse.ts
@@ -108,7 +108,7 @@ export function parse(
     if (node.type !== NodeTypes.ELEMENT) {
       return
     }
-    if (!node.children.length) {
+    if (!node.children.length && !hasSrc(node)) {
       return
     }
     switch (node.tag) {
@@ -188,9 +188,13 @@ function createBlock(
   pad: SFCParseOptions['pad']
 ): SFCBlock {
   const type = node.tag
-  const start = node.children[0].loc.start
-  const end = node.children[node.children.length - 1].loc.end
-  const content = source.slice(start.offset, end.offset)
+  let { start, end } = node.loc
+  let content = ''
+  if (node.children.length) {
+    start = node.children[0].loc.start
+    end = node.children[node.children.length - 1].loc.end
+    content = source.slice(start.offset, end.offset)
+  }
   const loc = {
     source: content,
     start,
@@ -275,3 +279,12 @@ function padContent(
     return Array(offset).join(padChar)
   }
 }
+
+function hasSrc(node: ElementNode) {
+  return node.props.some(p => {
+    if (p.type !== NodeTypes.ATTRIBUTE) {
+      return false
+    }
+    return p.name === 'src'
+  })
+}