From: Vladimír Čunát <vladimir.cunat@nic.cz>
Date: Thu, 4 Oct 2018 12:43:54 +0000 (+0200)
Subject: daemon/session nitpick: avoid a warning
X-Git-Tag: v3.1.0~10^2~9
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2d9ddd8d3c7321c9ea0cadd582bedb60e7126f0c;p=thirdparty%2Fknot-resolver.git

daemon/session nitpick: avoid a warning

lint:clang-scan-build reported:
> warning: The code calls sizeof() on a pointer type.
> This can produce an unexpected result
but in our case it's intentional.
(Yes, using pointers as keys in trie isn't very pretty.)
---

diff --git a/daemon/session.c b/daemon/session.c
index 0ae93c620..8ea88b905 100644
--- a/daemon/session.c
+++ b/daemon/session.c
@@ -148,7 +148,7 @@ int session_tasklist_add(struct session *session, struct qr_task *task)
 		key_len = sizeof(task_msg_id);
 	} else {
 		key = (const char *)&task;
-		key_len = sizeof(task);
+		key_len = sizeof(char *);
 	}
 	trie_val_t *v = trie_get_ins(t, key, key_len);
 	if (unlikely(!v)) {
@@ -179,7 +179,7 @@ int session_tasklist_del(struct session *session, struct qr_task *task)
 		key_len = sizeof(task_msg_id);
 	} else {
 		key = (const char *)&task;
-		key_len = sizeof(task);
+		key_len = sizeof(char *);
 	}
 	int ret = trie_del(t, key, key_len, &val);
 	if (ret == kr_ok()) {