From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Wed, 17 Jan 2024 20:26:09 +0000 (+0100)
Subject: [3.11] gh-38807: Fix race condition in Lib/trace.py (GH-110143) (GH-114207)
X-Git-Tag: v3.11.8~132
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2dca68935e4884216822d18debcbf9a8e252dc21;p=thirdparty%2FPython%2Fcpython.git

[3.11] gh-38807: Fix race condition in Lib/trace.py (GH-110143) (GH-114207)

Instead of checking if a directory does not exist and thereafter
creating it, directly call os.makedirs() with the exist_ok=True.
(cherry picked from commit 78fcde039a33d8463e34356d5462fecee0f2831a)

Co-authored-by: buermarc <44375277+buermarc@users.noreply.github.com>
---

diff --git a/Lib/trace.py b/Lib/trace.py
index fb9a423ea09f..761916b18097 100755
--- a/Lib/trace.py
+++ b/Lib/trace.py
@@ -258,8 +258,7 @@ class CoverageResults:
                 modulename = _modname(filename)
             else:
                 dir = coverdir
-                if not os.path.exists(dir):
-                    os.makedirs(dir)
+                os.makedirs(dir, exist_ok=True)
                 modulename = _fullmodname(filename)
 
             # If desired, get a list of the line numbers which represent
diff --git a/Misc/NEWS.d/next/Library/2023-09-22-22-17-45.gh-issue-38807.m9McRN.rst b/Misc/NEWS.d/next/Library/2023-09-22-22-17-45.gh-issue-38807.m9McRN.rst
new file mode 100644
index 000000000000..4219723d15b9
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2023-09-22-22-17-45.gh-issue-38807.m9McRN.rst
@@ -0,0 +1,3 @@
+Fix race condition in :mod:`trace`. Instead of checking if a directory
+exists and creating it, directly call :func:`os.makedirs` with the kwarg
+``exist_ok=True``.