From: Lennart Poettering <lennart@poettering.net>
Date: Fri, 15 Mar 2019 14:05:01 +0000 (+0100)
Subject: systemctl: start_unit() returns > 0 on error, let's catch that properly
X-Git-Tag: v242-rc1~94^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2e13c0c3547dd2e2d136a9f7f5f04d3f652269ee;p=thirdparty%2Fsystemd.git

systemctl: start_unit() returns > 0 on error, let's catch that properly

Let's make sure we fall back correctly to initctl when start_unit()
returns an error > 0.

Fixes: #11546
---

diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c
index caacfe06362..58f0305433e 100644
--- a/src/systemctl/systemctl.c
+++ b/src/systemctl/systemctl.c
@@ -8939,7 +8939,7 @@ static int reload_with_fallback(void) {
 
 static int start_with_fallback(void) {
         /* First, try systemd via D-Bus. */
-        if (start_unit(0, NULL, NULL) >= 0)
+        if (start_unit(0, NULL, NULL) == 0)
                 return 0;
 
         /* Nothing else worked, so let's try /dev/initctl */