From: Brad Allen <bradallen137@gmail.com>
Date: Thu, 18 Mar 2010 15:12:06 +0000 (-0600)
Subject: comments/question about using connection.closed in is_disconnect method
X-Git-Tag: rel_0_6beta2~39
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2e5bf818ba829dd5891116a491976cacdae248c9;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

comments/question about using connection.closed in is_disconnect method
---

diff --git a/lib/sqlalchemy/connectors/mxodbc.py b/lib/sqlalchemy/connectors/mxodbc.py
index d03fdb5ffc..030d5418ba 100644
--- a/lib/sqlalchemy/connectors/mxodbc.py
+++ b/lib/sqlalchemy/connectors/mxodbc.py
@@ -93,6 +93,8 @@ class MxODBCConnector(Connector):
         return args, kwargs
 
     def is_disconnect(self, e):
+        # eGenix recommends checking connection.closed here,
+        # but how can we get a handle on the current connection?
         if isinstance(e, self.dbapi.ProgrammingError):
             return "connection already closed" in str(e)
         elif isinstance(e, self.dbapi.Error):