From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Wed, 20 Nov 2019 10:16:02 +0000 (-0800)
Subject: bpo-38823: Fix refleak in marshal init error path (GH-17260)
X-Git-Tag: v3.8.1rc1~59
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2ea4c37c1ecf05a8495211d55ed6888439b1b9cf;p=thirdparty%2FPython%2Fcpython.git

bpo-38823: Fix refleak in marshal init error path (GH-17260)

(cherry picked from commit 33b671e72450bf4b5a946ce0dde6b7fe21150108)

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
---

diff --git a/Python/marshal.c b/Python/marshal.c
index b2daff2c8a3b..c6a06e8c2397 100644
--- a/Python/marshal.c
+++ b/Python/marshal.c
@@ -1829,6 +1829,9 @@ PyMarshal_Init(void)
     PyObject *mod = PyModule_Create(&marshalmodule);
     if (mod == NULL)
         return NULL;
-    PyModule_AddIntConstant(mod, "version", Py_MARSHAL_VERSION);
+    if (PyModule_AddIntConstant(mod, "version", Py_MARSHAL_VERSION) < 0) {
+        Py_DECREF(mod);
+        return NULL;
+    }
     return mod;
 }