From: Pavel Filipenský <pfilipen@redhat.com>
Date: Wed, 4 Aug 2021 16:41:21 +0000 (+0200)
Subject: s3:winbind: Improve logging in winbindd_getgrnam.c
X-Git-Tag: tevent-0.13.0~146
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2ec7ccabb3400b70ab3d039931787f8d8589af1a;p=thirdparty%2Fsamba.git

s3:winbind: Improve logging in winbindd_getgrnam.c

Test scenario:
bin/wbinfo --group-info 'ADDOMAIN/domain users'

Signed-off-by: Pavel Filipenský <pfilipen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source3/winbindd/winbindd_getgrnam.c b/source3/winbindd/winbindd_getgrnam.c
index d66506518e8..bdb8aba0009 100644
--- a/source3/winbindd/winbindd_getgrnam.c
+++ b/source3/winbindd/winbindd_getgrnam.c
@@ -56,7 +56,8 @@ struct tevent_req *winbindd_getgrnam_send(TALLOC_CTX *mem_ctx,
 	/* Ensure null termination */
 	request->data.groupname[sizeof(request->data.groupname)-1]='\0';
 
-	DBG_NOTICE("[%s (%u)] getgrnam %s\n",
+	D_NOTICE("[%s (%u)] Winbind external command GETGRNAM start.\n"
+		   "Searching group name '%s'.\n",
 		   cli->client_name,
 		   (unsigned int)cli->pid,
 		   request->data.groupname);
@@ -171,15 +172,15 @@ NTSTATUS winbindd_getgrnam_recv(struct tevent_req *req,
 
 	if (tevent_req_is_nterror(req, &status)) {
 		struct dom_sid_buf sidbuf;
-		DEBUG(5, ("Could not convert sid %s: %s\n",
+		D_WARNING("Could not convert sid %s: %s\n",
 			  dom_sid_str_buf(&state->sid, &sidbuf),
-			  nt_errstr(status)));
+			  nt_errstr(status));
 		return status;
 	}
 
 	if (!fill_grent(talloc_tos(), &response->data.gr, state->domname,
 			state->name, state->gid)) {
-		DEBUG(5, ("fill_grent failed\n"));
+		D_WARNING("fill_grent failed\n");
 		return NT_STATUS_NO_MEMORY;
 	}
 
@@ -197,5 +198,9 @@ NTSTATUS winbindd_getgrnam_recv(struct tevent_req *req,
 	response->extra_data.data = buf;
 	response->length += talloc_get_size(response->extra_data.data);
 
+	D_NOTICE("Winbind external command GETGRNAM end.\n"
+		 "Returning %u memmber(s).\n",
+		 response->data.gr.num_gr_mem);
+
 	return NT_STATUS_OK;
 }