From: Xtreak <tir.karthi@gmail.com>
Date: Wed, 1 May 2019 11:59:49 +0000 (+0530)
Subject: bpo-30458: Disable https related urllib tests on a build without ssl (GH-13032)
X-Git-Tag: v3.8.0a4~49
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2fc936ed24cf04ed32f6015a8aa78c8ea40da66b;p=thirdparty%2FPython%2Fcpython.git

bpo-30458: Disable https related urllib tests on a build without ssl (GH-13032)



These tests require an SSL enabled build. Skip these tests when python is built without SSL to fix test failures.


https://bugs.python.org/issue30458
---

diff --git a/Lib/test/test_urllib.py b/Lib/test/test_urllib.py
index e87c85b92876..c5b23f935b27 100644
--- a/Lib/test/test_urllib.py
+++ b/Lib/test/test_urllib.py
@@ -329,6 +329,7 @@ class urlopen_HttpTests(unittest.TestCase, FakeHTTPMixin, FakeFTPMixin):
         finally:
             self.unfakehttp()
 
+    @unittest.skipUnless(ssl, "ssl module required")
     def test_url_with_control_char_rejected(self):
         for char_no in list(range(0, 0x21)) + [0x7f]:
             char = chr(char_no)
@@ -354,6 +355,7 @@ class urlopen_HttpTests(unittest.TestCase, FakeHTTPMixin, FakeFTPMixin):
             finally:
                 self.unfakehttp()
 
+    @unittest.skipUnless(ssl, "ssl module required")
     def test_url_with_newline_header_injection_rejected(self):
         self.fakehttp(b"HTTP/1.1 200 OK\r\n\r\nHello.")
         host = "localhost:7777?a=1 HTTP/1.1\r\nX-injected: header\r\nTEST: 123"