From: Volker Lendecke <vl@samba.org>
Date: Thu, 11 Feb 2021 07:03:38 +0000 (+0100)
Subject: lib: Fix an uninitialized variable read
X-Git-Tag: tevent-0.11.0~1633
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2fc974fdfa75e89206a8c3537cbb2060e7c216b2;p=thirdparty%2Fsamba.git

lib: Fix an uninitialized variable read

If cli_rpc_pipe_open_noauth() fails, we end up in TALLOC_FREE() of
"p", which is uninitialized.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/lib/util_sd.c b/source3/lib/util_sd.c
index bcf152b22cf..d90d566cdb2 100644
--- a/source3/lib/util_sd.c
+++ b/source3/lib/util_sd.c
@@ -175,7 +175,7 @@ static NTSTATUS cli_lsa_lookup_name(struct cli_state *cli,
 				    struct dom_sid *sid)
 {
 	struct smbXcli_tcon *orig_tcon = NULL;
-	struct rpc_pipe_client *p;
+	struct rpc_pipe_client *p = NULL;
 	struct policy_handle handle;
 	NTSTATUS status;
 	TALLOC_CTX *frame = talloc_stackframe();