From: Lennart Poettering <lennart@poettering.net>
Date: Wed, 29 Apr 2020 14:24:41 +0000 (+0200)
Subject: home: mark various bus messages we write user records to as sensitive
X-Git-Tag: v246-rc1~451^2~1
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=2ffee2c9b059e0988662fb14ab1b19450258fdb0;p=thirdparty%2Fsystemd.git

home: mark various bus messages we write user records to as sensitive

let's make sure that when we append potentially sensitive data to a bus
message we set the sensitive flag on the message object.
---

diff --git a/src/home/home-util.c b/src/home/home-util.c
index 69ab645484d..51406fd2345 100644
--- a/src/home/home-util.c
+++ b/src/home/home-util.c
@@ -124,6 +124,8 @@ int bus_message_append_secret(sd_bus_message *m, UserRecord *secret) {
         if (r < 0)
                 return r;
 
+        (void) sd_bus_message_sensitive(m);
+
         return sd_bus_message_append(m, "s", formatted);
 }
 
diff --git a/src/home/homectl.c b/src/home/homectl.c
index 9b614325a50..c98bf8b5408 100644
--- a/src/home/homectl.c
+++ b/src/home/homectl.c
@@ -1435,6 +1435,8 @@ static int create_home(int argc, char *argv[], void *userdata) {
                 if (r < 0)
                         return bus_log_create_error(r);
 
+                (void) sd_bus_message_sensitive(m);
+
                 r = sd_bus_message_append(m, "s", formatted);
                 if (r < 0)
                         return bus_log_create_error(r);
@@ -1637,6 +1639,8 @@ static int update_home(int argc, char *argv[], void *userdata) {
                 if (r < 0)
                         return r;
 
+                (void) sd_bus_message_sensitive(m);
+
                 r = sd_bus_message_append(m, "s", formatted);
                 if (r < 0)
                         return bus_log_create_error(r);