From: JINMEI Tatuya <jinmei@isc.org>
Date: Fri, 26 Oct 2012 02:55:16 +0000 (-0700)
Subject: [2297] introduce a filter for process_rename test to prevent false positives
X-Git-Tag: trac2487_base~32^2~2^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=30873bc3691ff9be1d9ce56dfb4c3dc30e4dabbc;p=thirdparty%2Fkea.git

[2297] introduce a filter for process_rename test to prevent false positives

isc-sysinfo (now) isn't expected to be renamed, so shouldn't be tested.
---

diff --git a/src/bin/tests/process_rename_test.py.in b/src/bin/tests/process_rename_test.py.in
index 1156b29292..af7cc5ec91 100644
--- a/src/bin/tests/process_rename_test.py.in
+++ b/src/bin/tests/process_rename_test.py.in
@@ -39,6 +39,11 @@ class TestRename(unittest.TestCase):
         Then scan them by looking at the source text
         (without actually running them)
         """
+
+        # Scripts nameds contained in this list are not expected to be
+        # renamed and should be excluded from the list.
+        EXCLUDED_SCRIPTS = ['isc-sysinfo']
+
         # Regexp to find all the *_SCRIPTS = something lines (except for
         # noinst_SCRIPTS, which are scripts for tests), including line
         # continuations (backslash and newline)
@@ -59,6 +64,8 @@ class TestRename(unittest.TestCase):
                 for (var, _) in lines.findall(re.sub(excluded_lines, '',
                                                      makefile)):
                     for (script, _) in scripts.findall(var):
+                        if script in EXCLUDED_SCRIPTS:
+                            continue
                         self.__scan(d, script, fun)
 
 if __name__ == "__main__":