From: Jonathon Reinhart <JonathonReinhart@users.noreply.github.com>
Date: Mon, 5 Sep 2022 21:32:23 +0000 (-0400)
Subject: argparse: Remove unused name variable when handling ArgumentTypeError (#96549)
X-Git-Tag: v3.12.0a1~472
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=30878a7735f7d5cf2023f5b2758feee850b60700;p=thirdparty%2FPython%2Fcpython.git

argparse: Remove unused name variable when handling ArgumentTypeError (#96549)

This removes the unused `name` variable in the block where `ArgumentTypeError` is handled.

`ArgumentTypeError` errors are handled by showing just the string of the exception; unlike `ValueError`, the name (`__name__`) of the function is not included in the error message.

Fixes #96548
---

diff --git a/Lib/argparse.py b/Lib/argparse.py
index fe48f8670fa2..d2dcfdf5682f 100644
--- a/Lib/argparse.py
+++ b/Lib/argparse.py
@@ -2523,7 +2523,6 @@ class ArgumentParser(_AttributeHolder, _ActionsContainer):
 
         # ArgumentTypeErrors indicate errors
         except ArgumentTypeError as err:
-            name = getattr(action.type, '__name__', repr(action.type))
             msg = str(err)
             raise ArgumentError(action, msg)