From: Mauro Carvalho Chehab Date: Fri, 23 Apr 2021 15:19:12 +0000 (+0200) Subject: media: i2c: imx219: use pm_runtime_resume_and_get() X-Git-Tag: v5.14-rc1~165^2~306 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=30ad455912651abb79db379a2a2eaad00509ba87;p=thirdparty%2Fkernel%2Fstable.git media: i2c: imx219: use pm_runtime_resume_and_get() Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index 1054ffedaefd0..74a0bf9b088b2 100644 --- a/drivers/media/i2c/imx219.c +++ b/drivers/media/i2c/imx219.c @@ -1035,11 +1035,9 @@ static int imx219_start_streaming(struct imx219 *imx219) const struct imx219_reg_list *reg_list; int ret; - ret = pm_runtime_get_sync(&client->dev); - if (ret < 0) { - pm_runtime_put_noidle(&client->dev); + ret = pm_runtime_resume_and_get(&client->dev); + if (ret < 0) return ret; - } /* Apply default values of current mode */ reg_list = &imx219->mode->reg_list;