From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 16 Nov 2023 21:45:29 +0000 (+1300)
Subject: librpc:ndr: Don’t try to log always‐NULL string
X-Git-Tag: talloc-2.4.2~619
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=30dd348823c03adcf0e1bbf7adaa5ea1c30ca7a5;p=thirdparty%2Fsamba.git

librpc:ndr: Don’t try to log always‐NULL string

Commit c51795c747198f9e002505ffa39ad710beff0358 reorganized
ndr_pull_string() so that when we reach this DEBUG(), we don’t yet have
a string to log — ‘as’ will always be NULL. Attempting to log a NULL
string invokes undefined behaviour.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/librpc/ndr/ndr_string.c b/librpc/ndr/ndr_string.c
index 80054fa9be6..64a46655206 100644
--- a/librpc/ndr/ndr_string.c
+++ b/librpc/ndr/ndr_string.c
@@ -96,7 +96,7 @@ _PUBLIC_ enum ndr_err_code ndr_pull_string(struct ndr_pull *ndr, ndr_flags_type
 					      "Bad string lengths len1=%"PRIu32" ofs=%"PRIu32" len2=%"PRIu32"\n",
 					      len1, ofs, len2);
 		} else if (len1 != len2) {
-			DEBUG(6,("len1[%"PRIu32"] != len2[%"PRIu32"] '%s'\n", len1, len2, as));
+			DEBUG(6,("len1[%"PRIu32"] != len2[%"PRIu32"]\n", len1, len2));
 		}
 		conv_src_len = len2 + c_len_term;
 		break;