From: Mark Andrews <marka@isc.org>
Date: Mon, 2 May 2022 02:12:36 +0000 (+1000)
Subject: Remove unnecessary NULL pointer check
X-Git-Tag: v9.19.1~23^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=30f3d513682917cd0bb60a56efa25d39f121221f;p=thirdparty%2Fbind9.git

Remove unnecessary NULL pointer check

    3034                next = ISC_LIST_NEXT(query, link);
    3035        } else {
    3036                next = NULL;
    3037        }

    CID 352554 (#1 of 1): Dereference before null check (REVERSE_INULL)
    check_after_deref: Null-checking connectquery suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
    3038        if (connectquery != NULL) {
    3039                query_detach(&connectquery);
    3040        }
---

diff --git a/bin/dig/dighost.c b/bin/dig/dighost.c
index 7bbd4fafd20..1c58c4b88e4 100644
--- a/bin/dig/dighost.c
+++ b/bin/dig/dighost.c
@@ -3035,9 +3035,7 @@ failure_tls:
 	} else {
 		next = NULL;
 	}
-	if (connectquery != NULL) {
-		query_detach(&connectquery);
-	}
+	query_detach(&connectquery);
 	query_detach(&query);
 	if (next == NULL) {
 		clear_current_lookup();