From: Mike Marshall Date: Tue, 7 Apr 2026 15:25:54 +0000 (-0400) Subject: debugfs: take better advantage of strscpy. X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=30f5059dba163550fb830af68cbd28ce78b1e0d2;p=thirdparty%2Fkernel%2Flinux.git debugfs: take better advantage of strscpy. Signed-off-by: Mike Marshall --- diff --git a/fs/orangefs/orangefs-debugfs.c b/fs/orangefs/orangefs-debugfs.c index 51d574ab3a939..69bd73a2b5564 100644 --- a/fs/orangefs/orangefs-debugfs.c +++ b/fs/orangefs/orangefs-debugfs.c @@ -238,12 +238,10 @@ void orangefs_debugfs_init(int debug_mask) static void orangefs_kernel_debug_init(void) { static char k_buffer[ORANGEFS_MAX_DEBUG_STRING_LEN] = { }; - size_t len = strlen(kernel_debug_string); + size_t len = + strscpy(k_buffer, kernel_debug_string, sizeof(k_buffer) - 1); - gossip_debug(GOSSIP_DEBUGFS_DEBUG, "%s: start\n", __func__); - - if (len + 1 < ORANGEFS_MAX_DEBUG_STRING_LEN) { - memcpy(k_buffer, kernel_debug_string, len); + if (len > 0) { k_buffer[len] = '\n'; k_buffer[len + 1] = '\0'; } else { @@ -339,12 +337,10 @@ static int help_show(struct seq_file *m, void *v) static void orangefs_client_debug_init(void) { static char c_buffer[ORANGEFS_MAX_DEBUG_STRING_LEN] = { }; - size_t len = strlen(client_debug_string); - - gossip_debug(GOSSIP_DEBUGFS_DEBUG, "%s: start\n", __func__); + size_t len = + strscpy(c_buffer, client_debug_string, sizeof(c_buffer) - 1); - if (len + 1 < ORANGEFS_MAX_DEBUG_STRING_LEN) { - memcpy(c_buffer, client_debug_string, len); + if (len > 0) { c_buffer[len] = '\n'; c_buffer[len + 1] = '\0'; } else {