From: Raymond Hettinger Date: Sun, 4 May 2014 02:06:32 +0000 (-0700) Subject: Issue #21421: Add __slots__ to the MappingViews ABCs. X-Git-Tag: v3.5.0a1~1738 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3170d1cccb15d7ad94658944e3aba1a1e753adbf;p=thirdparty%2FPython%2Fcpython.git Issue #21421: Add __slots__ to the MappingViews ABCs. --- diff --git a/Lib/_collections_abc.py b/Lib/_collections_abc.py index faa1ff22ff40..62817236f9a8 100644 --- a/Lib/_collections_abc.py +++ b/Lib/_collections_abc.py @@ -440,6 +440,8 @@ Mapping.register(mappingproxy) class MappingView(Sized): + __slots__ = '_mapping', + def __init__(self, mapping): self._mapping = mapping @@ -452,6 +454,8 @@ class MappingView(Sized): class KeysView(MappingView, Set): + __slots__ = () + @classmethod def _from_iterable(self, it): return set(it) @@ -467,6 +471,8 @@ KeysView.register(dict_keys) class ItemsView(MappingView, Set): + __slots__ = () + @classmethod def _from_iterable(self, it): return set(it) @@ -489,6 +495,8 @@ ItemsView.register(dict_items) class ValuesView(MappingView): + __slots__ = () + def __contains__(self, value): for key in self._mapping: if value == self._mapping[key]: diff --git a/Misc/NEWS b/Misc/NEWS index 18c943e720d5..c61821223b23 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -73,6 +73,9 @@ Library Decimal.quantize() method in the Python version. It had never been present in the C version. +- Issue #21421: Add __slots__ to the MappingViews ABC. + Patch by Josh Rosenberg. + - Issue #21101: Eliminate double hashing in the C speed-up code for collections.Counter().