From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 23 Feb 2021 14:26:49 +0000 (+0100)
Subject: shared: fix memory leak in error path
X-Git-Tag: v248-rc2~1^2~2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3178014709074cc65ebbb4604f6da306e34e6ffb;p=thirdparty%2Fsystemd.git

shared: fix memory leak in error path

Coverity 1446676
---

diff --git a/src/shared/serialize.c b/src/shared/serialize.c
index 42fe5db3faf..23aac3ef527 100644
--- a/src/shared/serialize.c
+++ b/src/shared/serialize.c
@@ -175,7 +175,7 @@ int deserialize_dual_timestamp(const char *value, dual_timestamp *t) {
 }
 
 int deserialize_environment(const char *value, char ***list) {
-        char *unescaped;
+        _cleanup_free_ char *unescaped = NULL;
         int r;
 
         assert(value);
@@ -187,9 +187,10 @@ int deserialize_environment(const char *value, char ***list) {
         if (r < 0)
                 return log_error_errno(r, "Failed to unescape: %m");
 
-        r = strv_env_replace_consume(list, unescaped);
+        r = strv_env_replace_consume(list, TAKE_PTR(unescaped));
         if (r < 0)
                 return log_error_errno(r, "Failed to append environment variable: %m");
+
         return 0;
 }