From: Thomas Weißschuh <thomas@t-8ch.de>
Date: Sun, 16 Apr 2023 16:36:29 +0000 (+0200)
Subject: fadvise: always exit with EXIT_FAILURE on error
X-Git-Tag: v2.39-rc3~24^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3179b40c69fa93101fa1836b73aee108ab30cc6f;p=thirdparty%2Futil-linux.git

fadvise: always exit with EXIT_FAILURE on error

Also document it.

Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
---

diff --git a/misc-utils/fadvise.1.adoc b/misc-utils/fadvise.1.adoc
index b44059518e..dffbeaa5cf 100644
--- a/misc-utils/fadvise.1.adoc
+++ b/misc-utils/fadvise.1.adoc
@@ -41,6 +41,15 @@ If this option is omitted, 0 is used as default advice.
 
 include::man-common/help-version.adoc[]
 
+== EXIT STATUS
+
+*fadvise* has the following exit status values:
+
+*0*::
+success
+*1*::
+unspecified failure
+
 == AUTHORS
 
 mailto:yamato@redhat.com[Masatake YAMATO]
diff --git a/misc-utils/fadvise.c b/misc-utils/fadvise.c
index b16d036c03..9606fb44ec 100644
--- a/misc-utils/fadvise.c
+++ b/misc-utils/fadvise.c
@@ -158,5 +158,5 @@ int main(int argc, char ** argv)
 	if (do_close)
 		close(fd);
 
-	return rc;
+	return rc == 0 ? EXIT_SUCCESS : EXIT_FAILURE;
 }