From: Kent Overstreet Date: Fri, 2 Feb 2024 02:01:02 +0000 (-0500) Subject: bcachefs: time_stats: Check for last_event == 0 when updating freq stats X-Git-Tag: v6.7.5~9 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3183d7aa418b69462179016e711cc34a0220dc70;p=thirdparty%2Fkernel%2Fstable.git bcachefs: time_stats: Check for last_event == 0 when updating freq stats commit 7b508b323b2ec45be59769bd4e4aeba729c52cf6 upstream. This fixes spurious outliers in the frequency stats. Signed-off-by: Kent Overstreet Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/bcachefs/util.c b/fs/bcachefs/util.c index 84b142fcc3dfc..3b7c349f2665a 100644 --- a/fs/bcachefs/util.c +++ b/fs/bcachefs/util.c @@ -362,14 +362,15 @@ static inline void bch2_time_stats_update_one(struct bch2_time_stats *stats, bch2_quantiles_update(&stats->quantiles, duration); } - if (time_after64(end, stats->last_event)) { + if (stats->last_event && time_after64(end, stats->last_event)) { freq = end - stats->last_event; mean_and_variance_update(&stats->freq_stats, freq); mean_and_variance_weighted_update(&stats->freq_stats_weighted, freq); stats->max_freq = max(stats->max_freq, freq); stats->min_freq = min(stats->min_freq, freq); - stats->last_event = end; } + + stats->last_event = end; } static noinline void bch2_time_stats_clear_buffer(struct bch2_time_stats *stats,