From: Nick Mathewson <nickm@torproject.org>
Date: Tue, 17 Apr 2018 23:41:10 +0000 (-0400)
Subject: Add a redundant memset to node_get_pref_ipv6_orport()
X-Git-Tag: tor-0.3.4.1-alpha~138
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=31a450a5b69a88fd9f38b1ca043952009ffddbf7;p=thirdparty%2Ftor.git

Add a redundant memset to node_get_pref_ipv6_orport()

For whatever reason, clang's scan-build isn't sure that this
function actually initializes its output.
---

diff --git a/src/or/nodelist.c b/src/or/nodelist.c
index 71eee3fa21..81a5c944ac 100644
--- a/src/or/nodelist.c
+++ b/src/or/nodelist.c
@@ -1517,6 +1517,7 @@ node_get_pref_ipv6_orport(const node_t *node, tor_addr_port_t *ap_out)
 {
   node_assert_ok(node);
   tor_assert(ap_out);
+  memset(ap_out, 0, sizeof(*ap_out));
 
   /* Check ri first, because rewrite_node_address_for_bridge() updates
    * node->ri with the configured bridge address.