From: Volker Lendecke <vl@sernet.de>
Date: Sat, 16 Aug 2008 09:17:09 +0000 (+0200)
Subject: Attempt to fix Coverity ID 595
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=31ca7b2dbbbfbb3a55670b58c08ebda68888af7e;p=thirdparty%2Fsamba.git

Attempt to fix Coverity ID 595

is_ipaddress already dereferences "name", so the NULL check is pointless after
calling it.
---

diff --git a/source/libcli/nbt/nbtname.c b/source/libcli/nbt/nbtname.c
index 2025ef70e73..fbb9550655a 100644
--- a/source/libcli/nbt/nbtname.c
+++ b/source/libcli/nbt/nbtname.c
@@ -420,7 +420,7 @@ _PUBLIC_ void nbt_choose_called_name(TALLOC_CTX *mem_ctx,
 	n->scope = NULL;
 	n->type = type;
 
-	if (is_ipaddress(name) || name == NULL) {
+	if ((name == NULL) || is_ipaddress(name)) {
 		n->name = "*SMBSERVER";
 		return;
 	}