From: Steve Langasek Date: Wed, 9 May 2012 05:56:00 +0000 (+0200) Subject: Fix bug 8920, null dereference X-Git-Tag: samba-4.0.0alpha21~217 X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=31db7d298577f18d70b0a8241a92dc8a1dc782bd;p=thirdparty%2Fsamba.git Fix bug 8920, null dereference Description: Avoid null dereference in initialize_password_db() When initialize_password_db() is called with reload=True, it's assumed that the free_private_data member of pdb_methods is non-null. This is not necessarily the case, as the tdb backend has no private data and therefore no free function. Check to see if we have private data that needs freed before calling. Author: Steve Langasek Bug-Ubuntu: https://bugs.launchpad.net/bugs/829221 Autobuild-User: Volker Lendecke Autobuild-Date: Thu May 10 11:07:27 CEST 2012 on sn-devel-104 --- diff --git a/source3/passdb/pdb_interface.c b/source3/passdb/pdb_interface.c index 6945a4210cc..5931dde2d88 100644 --- a/source3/passdb/pdb_interface.c +++ b/source3/passdb/pdb_interface.c @@ -195,7 +195,9 @@ static struct pdb_methods *pdb_get_methods_reload( bool reload ) static struct pdb_methods *pdb = NULL; if ( pdb && reload ) { - pdb->free_private_data( &(pdb->private_data) ); + if (pdb->free_private_data != NULL) { + pdb->free_private_data( &(pdb->private_data) ); + } if ( !NT_STATUS_IS_OK( make_pdb_method_name( &pdb, lp_passdb_backend() ) ) ) { return NULL; }