From: Antoine Pitrou <solipsis@pitrou.net>
Date: Tue, 17 Dec 2013 23:28:36 +0000 (+0100)
Subject: Issue #20006: Fix sporadic failures in test_weakset.
X-Git-Tag: v3.4.0b2~186^2
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=320b39158ebfd63f25eb5f10dd65792334445eda;p=thirdparty%2FPython%2Fcpython.git

Issue #20006: Fix sporadic failures in test_weakset.
---

diff --git a/Lib/_weakrefset.py b/Lib/_weakrefset.py
index 6a98b88e3355..7f9923c6341a 100644
--- a/Lib/_weakrefset.py
+++ b/Lib/_weakrefset.py
@@ -60,6 +60,8 @@ class WeakSet:
             for itemref in self.data:
                 item = itemref()
                 if item is not None:
+                    # Caveat: the iterator will keep a strong reference to
+                    # `item` until it is resumed or closed.
                     yield item
 
     def __len__(self):
diff --git a/Lib/test/test_weakset.py b/Lib/test/test_weakset.py
index d8abe5e2b3bf..fb22879dfab9 100644
--- a/Lib/test/test_weakset.py
+++ b/Lib/test/test_weakset.py
@@ -370,9 +370,14 @@ class TestWeakSet(unittest.TestCase):
         def testcontext():
             try:
                 it = iter(s)
-                next(it)
+                # Start iterator
+                yielded = ustr(str(next(it)))
                 # Schedule an item for removal and recreate it
                 u = ustr(str(items.pop()))
+                if yielded == u:
+                    # The iterator still has a reference to the removed item,
+                    # advance it (issue #20006).
+                    next(it)
                 gc.collect()      # just in case
                 yield u
             finally: