From: Victor Julien <victor@inliniac.net>
Date: Mon, 16 Sep 2013 16:25:34 +0000 (+0200)
Subject: Coverity 1038089: error check fseek call
X-Git-Tag: suricata-2.0beta2~362
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=32503bafaa986e9249a9123a915c98b32422c634;p=thirdparty%2Fsuricata.git

Coverity 1038089: error check fseek call
---

diff --git a/src/util-error.c b/src/util-error.c
index 2cb7d38f7d..2ffb0df885 100644
--- a/src/util-error.c
+++ b/src/util-error.c
@@ -278,6 +278,7 @@ const char * SCErrorToString(SCError err)
         CASE_CODE (SC_ERR_THREAD_QUEUE);
         CASE_CODE (SC_WARN_XFF_INVALID_MODE);
         CASE_CODE (SC_WARN_XFF_INVALID_HEADER);
+        CASE_CODE (SC_ERR_THRESHOLD_SETUP);
     }
 
     return "UNKNOWN_ERROR";
diff --git a/src/util-error.h b/src/util-error.h
index c7494990fe..d9d58c0816 100644
--- a/src/util-error.h
+++ b/src/util-error.h
@@ -267,6 +267,7 @@ typedef enum {
     SC_ERR_THREAD_QUEUE,
     SC_WARN_XFF_INVALID_MODE,
     SC_WARN_XFF_INVALID_HEADER,
+    SC_ERR_THRESHOLD_SETUP,
 } SCError;
 
 const char *SCErrorToString(SCError);
diff --git a/src/util-threshold-config.c b/src/util-threshold-config.c
index fa7cc10a34..e064509056 100644
--- a/src/util-threshold-config.c
+++ b/src/util-threshold-config.c
@@ -920,7 +920,11 @@ int SCThresholdConfLineLength(FILE *fd) {
     if (pos < 0)
         pos = 0;
 
-    fseek(fd, pos, SEEK_SET);
+    if (fseek(fd, pos, SEEK_SET) < 0) {
+        SCLogError(SC_ERR_THRESHOLD_SETUP, "threshold fseek failure: %s",
+                strerror(errno));
+        return -1;
+    }
     return len;
 }