From: Peter Eisentraut <peter@eisentraut.org>
Date: Thu, 15 Jan 2026 09:24:49 +0000 (+0100)
Subject: plpython: Remove duplicate PyModule_Create()
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=3263a893fb1d2b36a44c13da701e44c805ed03f6;p=thirdparty%2Fpostgresql.git

plpython: Remove duplicate PyModule_Create()

This seems to have existed like this since Python 3 support was
added (commit dd4cd55c158), but it's unclear what this second call is
supposed to accomplish.

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com>
Reviewed-by: li carol <carol.li2025@outlook.com>
Reviewed-by: Kirill Reshke <reshkekirill@gmail.com>
Discussion: https://www.postgresql.org/message-id/f31333f1-fbb7-4098-b209-bf2d71fbd4f3%40eisentraut.org
---

diff --git a/src/pl/plpython/plpy_plpymodule.c b/src/pl/plpython/plpy_plpymodule.c
index 0d663ac5110..72867388653 100644
--- a/src/pl/plpython/plpy_plpymodule.c
+++ b/src/pl/plpython/plpy_plpymodule.c
@@ -151,8 +151,6 @@ PLy_init_plpy(void)
 	PLy_subtransaction_init_type();
 	PLy_cursor_init_type();
 
-	PyModule_Create(&PLy_module);
-
 	/*
 	 * initialize main module, and add plpy
 	 */