From: Mike Yuan <me@yhndnzj.com>
Date: Thu, 20 Nov 2025 12:52:51 +0000 (+0100)
Subject: core/exec-invoke: deduplicate needs_setuid with needs_sandboxing
X-Git-Url: http://git.ipfire.org/gitweb.cgi?a=commitdiff_plain;h=32b7a07b8c6cfd4804e381934e3c62234ec12dd5;p=thirdparty%2Fsystemd.git

core/exec-invoke: deduplicate needs_setuid with needs_sandboxing
---

diff --git a/src/core/exec-invoke.c b/src/core/exec-invoke.c
index 59808477d1c..1d4fa3756dc 100644
--- a/src/core/exec-invoke.c
+++ b/src/core/exec-invoke.c
@@ -5732,7 +5732,7 @@ int exec_invoke(
 
         /* We need setresuid() if the caller asked us to apply sandboxing and the command isn't explicitly
          * excepted from either whole sandboxing or just setresuid() itself. */
-        needs_setuid = (params->flags & EXEC_APPLY_SANDBOXING) && !(command->flags & (EXEC_COMMAND_FULLY_PRIVILEGED|EXEC_COMMAND_NO_SETUID));
+        needs_setuid = needs_sandboxing && !FLAGS_SET(command->flags, EXEC_COMMAND_NO_SETUID);
 
         uint64_t capability_ambient_set = context->capability_ambient_set;